-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] SideNavBar qa 해결 #451
Open
rtttr1
wants to merge
5
commits into
develop
Choose a base branch
from
refactor/snb/#447-snb-qa
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−96
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,3 +103,5 @@ export const IMAGE_MODAL = { | |
INFO_TEXT: '파일을 업로드 중입니다', | ||
}, | ||
}; | ||
|
||
export const MAX_TEAM_COUNT = 8; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,86 +1,70 @@ | ||
import { css } from "@emotion/react"; | ||
import { css } from '@emotion/react'; | ||
|
||
import { ToolTipProps } from "@/ToolTip/ToolTip"; | ||
import { theme } from "@/theme"; | ||
import { ToolTipProps } from '@/ToolTip/ToolTip'; | ||
import { theme } from '@/theme'; | ||
|
||
export const containerStyle = css({ | ||
display: "inline-block", | ||
position: "relative", | ||
display: 'inline-block', | ||
position: 'relative', | ||
}); | ||
|
||
export const messageStyle = (isVisible: boolean) => | ||
css({ | ||
position: "absolute", | ||
|
||
width: "max-content", | ||
padding: "1rem", | ||
borderRadius: "8px", | ||
position: 'absolute', | ||
|
||
width: 'max-content', | ||
padding: '0.9rem', | ||
borderRadius: '8px', | ||
border: `1px solid ${theme.colors.gray_900}`, | ||
backgroundColor: `${theme.colors.gray_900}`, | ||
font: `${theme.text.body08}`, | ||
color: `${theme.colors.white}`, | ||
|
||
visibility: isVisible ? "visible" : "hidden", | ||
visibility: isVisible ? 'visible' : 'hidden', | ||
|
||
transitionDelay: isVisible ? '0.2s' : '0', | ||
|
||
pointerEvents: 'none', | ||
|
||
transitionDelay: isVisible ? "0.2s" : "0", | ||
'&::after': { | ||
content: '""', | ||
position: 'absolute', | ||
|
||
pointerEvents: "none", | ||
right: '100%', | ||
transform: `translateY(-50%) translateX(calc(0 - 6px))`, | ||
|
||
borderWidth: '6px', | ||
borderStyle: 'solid', | ||
borderColor: `transparent ${theme.colors.gray_900} transparent transparent`, | ||
}, | ||
}); | ||
|
||
export const positionStyle = (position: Required<ToolTipProps>["position"], gap: number) => { | ||
export const positionStyle = ( | ||
position: Required<ToolTipProps>['position'], | ||
gap: number, | ||
) => { | ||
const style = { | ||
top: css({ | ||
left: "50%", | ||
bottom: "100%", | ||
left: '50%', | ||
bottom: '100%', | ||
transform: `translateX(-50%) translateY(calc(-${gap}rem - 8px) )`, | ||
}), | ||
bottom: css({ | ||
left: "50%", | ||
up: "100%", | ||
left: '50%', | ||
up: '100%', | ||
transform: `translateX(-50%) translateY(calc(${gap}rem + 8px))`, | ||
}), | ||
left: css({ | ||
top: "50%", | ||
right: "100%", | ||
top: '50%', | ||
right: '100%', | ||
transform: `translateY(-50%) translateX(calc(-${gap}rem - 8px))`, | ||
}), | ||
right: css({ | ||
top: "50%", | ||
left: "100%", | ||
top: '50%', | ||
left: '100%', | ||
transform: `translateY(-50%) translateX(calc(${gap}rem + 8px))`, | ||
}), | ||
}; | ||
|
||
return style[position]; | ||
}; | ||
|
||
export const arrowStyle = css({ | ||
position: "absolute", | ||
}); | ||
|
||
export const arrowPositionStyle = (position: Required<ToolTipProps>["position"]) => { | ||
const style = { | ||
top: css({ | ||
left: "50%", | ||
top: "calc(100%)", | ||
transform: `translateX(-50%) translateY(-1px) rotate(270deg)`, | ||
}), | ||
bottom: css({ | ||
left: "50%", | ||
bottom: "calc(100%)", | ||
transform: `translateX(-50%) translateY(1px) rotate(90deg)`, | ||
}), | ||
left: css({ | ||
top: "50%", | ||
left: "calc(100%)", | ||
transform: `translateY(-50%) translateX(-1px) rotate(180deg)`, | ||
}), | ||
right: css({ | ||
top: "50%", | ||
right: "calc(100%)", | ||
transform: `translateY(-50%) translateX(1px)`, | ||
}), | ||
}; | ||
|
||
return style[position]; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요고는 기디측의 요구사항이였나용 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 8개 이상이 되면 아이콘들이 겹치는 뷰가 나와서 마우스 스크롤 보다는 개수제한이 리소스적으로 나을것 같아서 일단 개수제한을 두기로 했습니다!