[feat] Button 컴포넌트 구현 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
18 tasks
jihyunniiii
reviewed
Jul 6, 2024
There was a problem hiding this comment.
미리 말씀을 못 드려서 죄송합니다,,
버튼이 동작하는 기능들은 모두 같으니 해당 동작을 수행하는 BaseButton을 하나 만든 뒤 이를 이용하여 나머지 버튼들을 구현하면 조금 더 효율적인 코드가 될 것 같아요! modifier, shape, enabled, 그리고 활성화와 비활성화일 때 background 색상, onClick 메소드, content 를 인자로 받아오면 좋을 것 같습니다 (추가적으로 공통으로 빼면 좋겠다고 생각하는 부분이 있으면 말해주세요!)
혹시 이해가 안 되신다면 바로 말씀해 주시고 모르겠으면 저랑 이따 같이 해봐용
수고하셨습니다 ~
추가로 중복되는 부분이 많아 위에만 리뷰 달아두었어요 전체적으로 고쳐주세용
app/src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadAddCourseButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadAddCourseButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadAddCourseButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadAddCourseButton.kt
Outdated
Show resolved
Hide resolved
t1nm1ksun
approved these changes
Jul 7, 2024
app/src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadAddCourseButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadBasicButton.kt
Outdated
Show resolved
Hide resolved
Comment on lines
35
to
40
| Text( | ||
| text = "불러오기", | ||
| style = DateRoadTheme.typography.bodyMed13, | ||
| color = contentColor, | ||
| modifier = Modifier.align(Alignment.CenterVertically) | ||
| ) |
There was a problem hiding this comment.
string 추출 안해줘도 될까요?
이 부분은 제가 설정하는게 아니라, 따로 받아오는 거라 안했습니다!
| horizontalArrangement = Arrangement.Center | ||
| ) { | ||
| Text( | ||
| text = "데이트 코스 올리고 50P 받기", |
t1nm1ksun
approved these changes
Jul 7, 2024
app/src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadFilledButton.kt
Outdated
Show resolved
Hide resolved
jihyunniiii
approved these changes
Jul 7, 2024
app/src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadFilledButton.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadKakaoLoginButton.kt
Show resolved
Hide resolved
...src/main/java/org/sopt/dateroad/presentation/ui/component/button/DateRoadKakaoLoginButton.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢