[feat] Place Card 컴포넌트 구현 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2hyunjinn
requested changes
Jul 7, 2024
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Outdated
Show resolved
Hide resolved
jihyunniiii
reviewed
Jul 8, 2024
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Outdated
Show resolved
Hide resolved
jihyunniiii
approved these changes
Jul 8, 2024
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/component/placecard/DateRoadPlaceCard.kt
Outdated
Show resolved
Hide resolved
2hyunjinn
requested changes
Jul 8, 2024
Comment on lines
+33
to
+35
| placeCardType: PlaceCardType, | ||
| placeTimeline: String? = null, | ||
| place: Place, |
There was a problem hiding this comment.
이거 Entity로 받아와야 하는 거 아닌가요!
There was a problem hiding this comment.
place가 Entity고 TImeline은 index값 따로 받아오기로 했습니다!
2hyunjinn
approved these changes
Jul 8, 2024
# Conflicts: # app/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢