Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Dialog 컴포넌트 #37

Merged
merged 10 commits into from
Jul 8, 2024
Merged

[feat] Dialog 컴포넌트 #37

merged 10 commits into from
Jul 8, 2024

Conversation

t1nm1ksun
Copy link
Member

@t1nm1ksun t1nm1ksun commented Jul 8, 2024

Related issue 🛠

Work Description ✏️

  • DateRoadOneButtonDialog
  • DateRoadOneButtonDialogWithDescription
  • DateRoadOneDialog
  • DateRoadOneDialogWithDescription

Screenshot 📸

  • DateRoadOneButtonDialog
2024-07-08.2.35.04.mov
  • DateRoadOneButtonDialogWithDescription
2024-07-08.2.36.12.mov
  • DateRoadTwoButtonDialog
2024-07-08.2.31.36.mov
  • DateRoadTwoButtonDialogWithDescription
2024-07-08.2.31.56.mov

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialog(
onDismissRequest = onDismissRequest,
content
)

이거 컴포즈에서 기본적으로 제공되는 다이얼로그가 있는데요 이거 이용해서 내부 content를 집어넣는 방식으로 구현해 주세요 다른 거 했던 거처럼 Base를 만들어도 좋구요 ~

이제 야무지게 혼자서도 잘 하네 ㄷㄷ 다 컸다

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 했당 ~

Copy link
Contributor

@2hyunjinn 2hyunjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

갈수록 실력이 ㄷ ㄷ,, 리드하셔도 되겠어요!

@t1nm1ksun t1nm1ksun merged commit f468d5c into develop Jul 8, 2024
1 check passed
@t1nm1ksun t1nm1ksun deleted the feat-dialog-component branch July 8, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] Dialog 컴포넌트
3 participants