Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 마이페이지 개별 컴포넌트 구현 #43

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

t1nm1ksun
Copy link
Member

Related issue 🛠

Work Description ✏️

  • PointInfoType 제작
  • PointInfo 구현
  • MyPageButtonType 제작
  • MyPageButton 구현

Screenshot 📸

image image

Uncompleted Tasks 😅

  • 없습니다!

To Reviewers 📢

컴포넌트 거의 끝이 보여요...!!

Copy link
Contributor

@2hyunjinn 2hyunjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨어요~

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고고 야무지댱

Comment on lines 13 to 14
val cornerRadius: Dp = 14.dp,
val padding: Dp = 16.dp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얜 타입으로 안 빼도 될 것 같은데요??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

심지어 여기 패딩 16도 아님 ㅋㅋ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14네 ㅋㅋ
눈 침침 침튜브 이슈

.padding(start = 16.dp, top = 19.dp, end = 16.dp, bottom = 20.dp)
.fillMaxWidth()
.clickable(onClick = onClick),
verticalAlignment = Alignment.CenterVertically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

없어도 될 것 같네요

.clickable(onClick = onClick),
verticalAlignment = Alignment.CenterVertically
) {
Text(text = stringResource(id = myPageMenuType.titleRes), modifier = Modifier.weight(1f))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextStyle, Color 값 넣으세용

import org.sopt.dateroad.ui.theme.DateRoadTheme

@Composable
fun DateRoadMyPagePointInfo(myPagePointInfoType: MyPagePointInfoType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기기대응 진행해 주세요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얜 지워주시와요

@@ -67,6 +67,16 @@
<string name="money_tag_less_than_50000">5만원 이하</string>
<string name="money_tag_less_than_30000">3만원 이하</string>

<!-- My Page Point Info -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- My Page Point Info -->
<!-- MyPagePointInfoType -->

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘하는데요 ~

@t1nm1ksun t1nm1ksun merged commit 345c1f3 into develop Jul 8, 2024
1 check passed
@t1nm1ksun t1nm1ksun deleted the feat-mypage-component branch July 8, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 마이페이지 개별 컴포넌트 구현
3 participants