fix: subscription groups use invalid channel id length #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
This is an automated message generated by Sweep AI. |
|
I think we can add an IndexedDB migration to fetch the user's subscriptions, and then find the appropriate 24 character channel id from it. |
|
Right, good idea 👍 |
|
I've added some migrations now, and tested with a few channels and groups and seems to be working fine, the database is being updated properly. |
Bnyro
force-pushed
the
fix-channel-id
branch
from
bf7387a to
9e30798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHOOPS
Merging this would break compatibility with current channel groups however, not sure what the best way to work around this.
(Noticed when working on import/export compatibility with LibreTube.)