Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Share Button #3642

Merged
merged 2 commits into from
May 25, 2024
Merged

Fix: Share Button #3642

merged 2 commits into from
May 25, 2024

Conversation

dragos-efy
Copy link
Contributor

No description provided.

Copy link
Contributor

sweep-ai bot commented May 23, 2024

Sweep: PR Review

Authors of pull request: @dragos-efy

This pull request focused on improving the user interface and code organization for the ShareModal and WatchVideo components.

In ShareModal.vue, the alignment of the buttons was changed by removing the justify-end class from the div containing the buttons. This adjustment altered the button alignment from right-aligned to default-aligned within the flex container.

In WatchVideo.vue, the CSS rules for the .player-container class were refactored to use nested selectors for better readability and maintainability. The styles for .pp-trans and .pp-solid were nested under .player-container, ensuring that the specific video track display styles are applied correctly based on the container's class.

These changes enhance the visual consistency and maintainability of the codebase.


Sweep Found These Issues

src/components/ShareModal.vue
  • Removing the justify-end class will change the alignment of the buttons from right-aligned to left-aligned, which may not be the intended visual layout.
  • <div class="flex flex-wrap" style="gap: var(--efy_gap0)">

    View Diff

src/components/WatchVideo.vue
  • The removal of the media query for .share-btn might cause layout issues on screens with a width of 768px or less.
  • video::cue {
    background: transparent;
    }
    .player-container {
    &.pp-trans video::-webkit-media-text-track-display {
    background: transparent !important;
    backdrop-filter: none;
    margin-bottom: unset;
    line-height: 1.2;
    text-shadow: 0 0 5rem #000;
    }
    &.pp-solid video::-webkit-media-text-track-display {
    background: var(--efy_bg) !important;
    color: var(--efy_text);
    backdrop-filter: none;
    }
    }
    @media (max-width: 639px) {
    video::-webkit-media-text-track-display {

    View Diff


The following files were not reviewed because our filter identified them as typically non-human-readable or less important files (e.g., dist files, package.json, images). If this is an error, please let us know.

  • package.json
  • pnpm-lock.yaml

@Bnyro Bnyro merged commit e70a090 into TeamPiped:efy May 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants