Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tests and created custom hook #266

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Updated tests and created custom hook #266

merged 9 commits into from
Apr 25, 2024

Conversation

joyguptaa
Copy link
Contributor

Summary

  1. Updated tests wrt msw
  2. Created a custom hook for redirection
  3. Increased the code coverage to 100%

TESTS

Screenshot 2024-04-23 at 10 07 28 PM Screenshot 2024-04-23 at 10 13 19 PM

Screenshots or Recordings (Optional)

Redirection part is working

Screen.Recording.2024-04-13.at.11.34.38.PM.mov

Checklist

  • I have tested the changes locally and they work as expected.
  • I have added/updated tests that cover the changes.
  • I have updated the documentation to reflect the changes.
  • This pull request follows the project's coding guidelines.

VinayakaHegade
VinayakaHegade reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@VinayakaHegade VinayakaHegade left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any particular reason behind test file name not being useCounterdownTimer.test.js?
Rest looks good to me.

client/src/hooks/__tests__/useRedirect.test.js Outdated
@@ -0,0 +1,66 @@
import {renderHook, act} from '@testing-library/react-hooks';
import useCountdownTimer from '../useCountdownTimer'; // Assuming this is the correct import path for your custom hook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please remove this comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@joyguptaa
Copy link
Contributor Author

is there any particular reason behind test file name not being useCounterdownTimer.test.js? Rest looks good to me.

Nope, just update it

@aps08 aps08 merged commit 1a2fa7e into dev Apr 25, 2024
2 checks passed
@aps08 aps08 deleted the test/adding-msw-to-email-verification branch April 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinayakaHegade VinayakaHegade VinayakaHegade approved these changes

@aps08 aps08 aps08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyguptaa @aps08 @VinayakaHegade