-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message filter for shared chat from other rooms #334
base: master
Are you sure you want to change the base?
Conversation
Looks good so far, I am gonna wait with the merge till your investigation is done |
yes most |
Yeah, I was thinking that was the case, unfortunately I didn't have any subs/raids in the shared-chat stream my bot was working in yesterday to verify in debug logs. I'll move the logic up one level to just before the handler logic: Separately your list of ((
)) |
ok, so it isn't needed for subscription notices, because they have
I'll remove the commit that moves where the filter lives as I think given we have |
70472a3
to
f200456
Compare
Twitch is rolling out shared chat rooms between streamers, and it can result in a bot responding to commands or messages from other chatrooms. This adds an optional (default on) filter for messages to only pay attention to the message if has a
source-room-id
that matches the currentroom-id
. I'm still investigating to see if this needs to be one level higher in the stack to also handle chat events likeRAID
andSUB