-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GetActiveSpecGroup() now just always returns 1. Instead we want to use the index of the active specialization. This does mean that previously-saved per-spec settings will now potentially apply to the wrong spec, but there's not much we can do about that.
- Loading branch information
Showing
1 changed file
with
10 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3712a58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's so few per-spec things now, I want to eventually default to per-char settings, and make per-spec something a module has to choose to use.
But effort... feeeeh
3712a58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greater Blessings are definitely per-spec. Holy doesn't even have them. I have no idea if prot does. Ideally Cork would recognize that Holy doesn't have them and only offer it as a per-char setting that only takes effect if the current spec offers it, but I'm not aware offhand if precedent for that sort of behavior so I jury copied the existing behavior for self and raid buffers.
3712a58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah but there's the fun bit, it's Ret-only now. So other specs won't have a different config, they'll just disable since the spells aren't available to them.
Honestly, even in the old specs, the majority of buffs available to multiple specs of the same class would have the same config (I always want Mark and Fort and ArcInt (except warriors and rogues lolol))... Paladin's "I'm a pretty and unique butterfly!" buffs were the exception (before normalizing raid buffs). These days? Fuck it all ^^
Anyway, true per-char settings is a dream really, I sorta doubt I'll get the bug up my ass to completely rewrite that stuff anytime soon, if ever.