feat：流水线查看和构建详情查看配置界面敏感字段展示优化 #11399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/backend/ci/core/store/biz-store/src/main/kotlin/com/tencent/devops/store/atom/service/impl/OpAtomServiceImpl.kt # src/backend/ci/core/store/biz-store/src/main/kotlin/com/tencent/devops/store/common/service/impl/StoreReleaseServiceImpl.kt
yjieliang
requested review from
stubenhuang,
carlyin0801,
royalhuang,
randychen2046 and
tangruotian
as code owners
carlyin0801
reviewed
Jan 13, 2025
| val version = element.version | ||
| val hashKey = if (version.contains(".*")) { | ||
| var latestVersion: String? = null | ||
| val atomVersionTestFlag = |
There was a problem hiding this comment.
store的逻辑挪到store去实现，通过service接口调用，另外redis的key值以后避免跨微服务使用，这样以后利于redis拆分
| val atomVersionTestFlag = | ||
| redisOperation.hget("$ATOM_POST_VERSION_TEST_FLAG_KEY_PREFIX:$atomCode", version) | ||
| // 项目下调试插件处理 | ||
| if (projectTestAtomCodes.contains(atomCode) && (atomVersionTestFlag == "true")) { |
There was a problem hiding this comment.
atomVersionTestFlag转成布尔值再使用比atomVersionTestFlag == "true"可读性更好
| } else { | ||
| version | ||
| } | ||
| val param = redisOperation.hget( |
There was a problem hiding this comment.
调试项目下的插件版本（可能有测试版本）和一般的项目不一样，你这样缓存到redis有问题，这个逻辑根本不需要写，你通过com.tencent.devops.store.atom.service.impl.MarketAtomEnvServiceImpl#batchGetAtomRunInfos这个接口就可以拿到对应数据
carlyin0801
reviewed
Feb 10, 2025
| val atomCode = atomRecord.atomCode | ||
| val version = atomRecord.version | ||
| var atomStatus = AtomStatusEnum.TESTING // 构建成功将插件状态置位测试状态 |
| stage.containers.forEach { container -> | ||
| container.elements.forEach { e -> | ||
| elementSensitiveParamInfos?.let { | ||
| pipelineInfoService.transferSensitiveParam(e, it) |
There was a problem hiding this comment.
确认这么转换会不会影响历史逻辑，有些逻辑需要使用参数的明文值
| @@ -164,7 +169,8 @@ class PipelineBuildRecordService @Autowired constructor( | |||
| buildInfo: BuildInfo, | |||
| executeCount: Int?, | |||
| refreshStatus: Boolean = true, | |||
| queryDslContext: DSLContext? = null | |||
| queryDslContext: DSLContext? = null, | |||
| editPermission: Boolean? = true | |||
There was a problem hiding this comment.
editPermission这个参数调用链条太长了，其实只要不是异步调用，一般的请求完全都可以从header中就可以拿到用户信息去判断
| @BkInterfaceI18n( | ||
| keyPrefixNames = ["ATOM", "{data[*].atomCode}", "{data[*].version}", "releaseInfo"] | ||
| ) | ||
| fun getTestAtoms( |
# Conflicts: # src/backend/ci/core/process/biz-base/src/main/kotlin/com/tencent/devops/process/engine/service/PipelineRepositoryService.kt # src/backend/ci/core/store/biz-store/src/main/kotlin/com/tencent/devops/store/atom/service/impl/OpAtomServiceImpl.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
流水线查看和构建详情查看配置界面敏感字段展示优化
没有流水线编辑权限的用户查看的流水线编排敏感字段将会进行加密