feat: openapi新增度量能力 #9638 #9670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7367fcb.
yongyiduan
requested review from
irwinsun,
mingshewhe and
stubenhuang
as code owners
yongyiduan
requested review from
carlyin0801,
royalhuang,
randychen2046 and
tangruotian
as code owners
royalhuang
approved these changes
Nov 9, 2023
irwinsun
reviewed
Nov 11, 2023
.../core/openapi/biz-openapi/src/main/kotlin/com/tencent/devops/openapi/dao/MetricsForApiDao.kt
Show resolved
Hide resolved
irwinsun
reviewed
Nov 11, 2023
| perDay: Boolean | ||
| ): Int { | ||
| return with(TOpenapiMetricsForApi.T_OPENAPI_METRICS_FOR_API) { | ||
| dslContext.batch( |
irwinsun
reviewed
Nov 11, 2023
| ): Int { | ||
| return with(TOpenapiMetricsForProject.T_OPENAPI_METRICS_FOR_PROJECT) { | ||
| dslContext.batch( | ||
| metricsApis.mapNotNull { metricsApi -> |
irwinsun
reviewed
Nov 11, 2023
| } | ||
| val projects = mutableListOf<MetricsProjectData>() | ||
| esServiceImpl.executeElasticsearchQueryP(projects) | ||
| projectDao.createOrUpdate(dslContext, projects) |
There was a problem hiding this comment.
projects 可能会是一个极大的List， 组装DAO SQL可能会超出单条SQL提交的大小
There was a problem hiding this comment.
esServiceImpl.executeElastisearchQueryP 遍历全量查询会否导致内存不足？假设有上百万个项目
irwinsun
reviewed
Nov 11, 2023
| } | ||
| apiDao.createOrUpdate( | ||
| dslContext = dslContext, | ||
| metricsApis = keyMap.values.toList(), |
There was a problem hiding this comment.
keyMap是 api 与 appcode/user 的笛卡尔积。 有可能也是一个非常大的数量
…际情况进行定时任务的性能优化
…际情况进行定时任务的性能优化
irwinsun
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: openapi新增度量能力 #9638