-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tg post NetError and update docker compose deploy #28
Conversation
Reviewer's Guide by SourceryThis pull request fixes a network error when posting to Telegram and updates the Docker Compose deployment configuration. Sequence diagram for updated Telegram posting processsequenceDiagram
participant P as Pipeline
participant T as TelegramSender
participant TB as TelegramBot
P->>T: send_text(message)
activate T
Note over T: Retry up to 10 times
Note over T: (increased from 5)
T->>TB: send_message()
Note over TB: Increased timeouts:
Note over TB: read: 60s
Note over TB: write: 60s
Note over TB: connect: 60s
Note over TB: pool: 600s
alt Network Error
TB-->>T: Network Error
T->>T: Retry with random delay (3-15s)
else Success
TB-->>T: Success
end
T-->>P: Complete
deactivate T
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Tohrusky - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the commented-out qb-ee service configuration instead of leaving it in the docker-compose file. If it's needed for reference, it should be documented elsewhere.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
read_timeout=60, | ||
write_timeout=60, | ||
connect_timeout=60, | ||
pool_timeout=600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): The timeout values seem unnecessarily high for a Telegram message operation
Consider reducing these timeout values. 600 seconds for pool_timeout and 60 seconds for other timeouts might be excessive for sending a message.
read_timeout=60, | |
write_timeout=60, | |
connect_timeout=60, | |
pool_timeout=600, | |
read_timeout=10, | |
write_timeout=10, | |
connect_timeout=10, | |
pool_timeout=30, |
Summary by Sourcery
Update post info generation timing and retry attempts for Telegram posts. Update qBittorrent image to
linuxserver/qbittorrent:latest
and expose additional ports.Bug Fixes:
NetworkError
issue in Telegram posts by increasing the retry attempts from 5 to 10 and adding timeouts for network requests.Enhancements:
Deployment:
linuxserver/qbittorrent:latest
image and expose ports 48008 for both TCP and UDP.