Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default template #26

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat: add default template #26

merged 1 commit into from
Dec 18, 2024

Conversation

Tohrusky
Copy link
Member

@Tohrusky Tohrusky commented Dec 18, 2024

Summary by Sourcery

New Features:

  • Introduce a default template script for video processing using VapourSynth.

Copy link

sourcery-ai bot commented Dec 18, 2024

Reviewer's Guide by Sourcery

This PR adds a default template for video processing that includes a basic VapourSynth script to load video sources. The implementation uses environment variables for flexible source configuration with a fallback to a default source file.

Class diagram for the default template

classDiagram
    class DefaultTemplate {
        +VideoSource(source: str)
        +set_output()
    }

    note for DefaultTemplate "Uses environment variable FINALRIP_SOURCE for source configuration with a fallback to 's.mkv'."
Loading

File-Level Changes

Change Details Files
Added a basic VapourSynth template for video source loading
  • Implemented environment variable 'FINALRIP_SOURCE' for configurable input source
  • Added fallback to default source file 's.mkv'
  • Set up basic clip output configuration
templates/default.py
templates/default_h264_8bit.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Tohrusky - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider making the default source filename more explicit (e.g., 'input.mkv') or requiring FINALRIP_SOURCE to be set instead of using 's.mkv' as a fallback
  • The default_h264_8bit.txt file appears to be empty - was this intentional?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Tohrusky Tohrusky merged commit a880f3c into TensoRaws:main Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant