Skip to content

Commit

Permalink
Release Candidate 1
Browse files Browse the repository at this point in the history
  • Loading branch information
Tercioo committed Jan 4, 2023
1 parent 332c47b commit da5481c
Show file tree
Hide file tree
Showing 9 changed files with 77 additions and 9 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ functions/pack2.lua
wowapi.lua
plugins/Details_TinyThreat/Details_TinyThreat_original.lua
*.png
Descriptions.lua
2 changes: 1 addition & 1 deletion Libs/DF/fw.lua
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@


local dversion = 409
local dversion = 410
local major, minor = "DetailsFramework-1.0", dversion
local DF, oldminor = LibStub:NewLibrary(major, minor)

Expand Down
38 changes: 37 additions & 1 deletion Libs/LibOpenRaid/LibOpenRaid.lua
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ if (WOW_PROJECT_ID ~= WOW_PROJECT_MAINLINE and not isExpansion_Dragonflight()) t
end

local major = "LibOpenRaid-1.0"
local CONST_LIB_VERSION = 90
local CONST_LIB_VERSION = 91

if (not LIB_OPEN_RAID_MAX_VERSION) then
LIB_OPEN_RAID_MAX_VERSION = CONST_LIB_VERSION
Expand Down Expand Up @@ -712,6 +712,7 @@ end
["playerPetChange"] = {},
["mythicDungeonEnd"] = {},
["unitAuraRemoved"] = {},
["cleanUpData"] = {},
}

openRaidLib.internalCallback.RegisterCallback = function(event, func)
Expand Down Expand Up @@ -773,6 +774,13 @@ end
--using random time, players won't trigger all at the same time
local randomTime = 0.3 + math.random(0, 0.7)
openRaidLib.Schedules.NewUniqueTimer(randomTime, openRaidLib.mainControl.SendFullData, "mainControl", "sendFullData_Schedule")

local groupSize = GetNumGroupMembers()
if (groupSize < openRaidLib.currentGroupSize) then
--a member left the group and the group size is smaller, trigger an event to modules clean up data
openRaidLib.Schedules.NewUniqueTimer(2, openRaidLib.mainControl.CleanUpData, "mainControl", "sendCleanUpData_Schedule")
openRaidLib.currentGroupSize = groupSize
end
end

openRaidLib.UpdateUnitIDCache()
Expand All @@ -791,6 +799,9 @@ end
["PLAYER_ENTERING_WORLD"] = function(...)
--has the selected character just loaded?
if (not openRaidLib.bHasEnteredWorld) then
--save the amount of members in the group
openRaidLib.currentGroupSize = GetNumGroupMembers()

--register events
openRaidLib.OnEnterWorldRegisterEvents()

Expand Down Expand Up @@ -1060,6 +1071,10 @@ end
openRaidLib.publicCallback.TriggerCallback("UnitAlive", "player")
end

function openRaidLib.mainControl.CleanUpData()
openRaidLib.internalCallback.TriggerEvent("cleanUpData")
end

openRaidLib.internalCallback.RegisterCallback("onEnterWorld", openRaidLib.mainControl.onEnterWorld)
openRaidLib.internalCallback.RegisterCallback("onEnterWorld", openRaidLib.mainControl.scheduleUpdatePlayerData)
openRaidLib.internalCallback.RegisterCallback("onEnterGroup", openRaidLib.mainControl.OnEnterGroup)
Expand Down Expand Up @@ -2110,6 +2125,26 @@ end
end
end

function openRaidLib.CooldownManager.OnCleanUpCall()
--the group has less players, need to check which players isn't in the group anymore and remove them from the cooldown database
--get the cooldown database table with all players
local cooldownDatabase = openRaidLib.CooldownManager.UnitData
local bAnyUnitGotRemoved = false
--foreach player in the database
for unitName in pairs(cooldownDatabase) do
--check if the player is in the group
if (not UnitInRaid(unitName) and not UnitInParty(unitName)) then
--remove the player from the database
openRaidLib.CooldownManager.UnitData[unitName] = nil
bAnyUnitGotRemoved = true
end
end

if (bAnyUnitGotRemoved) then

end
end

openRaidLib.internalCallback.RegisterCallback("onLeaveGroup", openRaidLib.CooldownManager.OnPlayerLeaveGroup)
openRaidLib.internalCallback.RegisterCallback("playerCast", openRaidLib.CooldownManager.OnPlayerCast)
openRaidLib.internalCallback.RegisterCallback("onPlayerRess", openRaidLib.CooldownManager.OnPlayerRess)
Expand All @@ -2119,6 +2154,7 @@ end
openRaidLib.internalCallback.RegisterCallback("mythicDungeonStart", openRaidLib.CooldownManager.OnMythicPlusStart)
openRaidLib.internalCallback.RegisterCallback("playerPetChange", openRaidLib.CooldownManager.OnPlayerPetChanged)
openRaidLib.internalCallback.RegisterCallback("unitAuraRemoved", openRaidLib.CooldownManager.OnAuraRemoved)
openRaidLib.internalCallback.RegisterCallback("cleanUpData", openRaidLib.CooldownManager.OnCleanUpCall)

--send a list through comm with cooldowns added or removed
function openRaidLib.CooldownManager.CheckCooldownChanges()
Expand Down
25 changes: 25 additions & 0 deletions boot.lua
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,31 @@ do
local Loc = _G.LibStub("AceLocale-3.0"):GetLocale( "Details" )

local news = {
{"v10.0.2.10333.147", "Jan 04th, 2023"},

"Enemy Cast (non-interrupted) now is shown in the death log.",
"Damage Done by Blessing of Winter and Summer now counts torward the paladin.",
"Tooltips for Mythic Dungeon segments in the segments menu, now brings more information about the combat.",
"List of Potions updated (Jooooo)",
"Priest Spirit of Redemption now shows in the Death Log breakdown.",
"/keystone doesn't show the player realm anymore",
"When importing a profile, the confirmation box (asking a name for the new profile) got a check box to opt-out of importing Code.",
"Major fixes for Guild Sync and Statistics window: /details stats",
"Raid Check (plugin): Added M+ Score and fixed the flask usage.",
"Streamer (plugin): Fixed the plugin window hidding after login.",
"Fixed Evoker and several other cooldowns which wasn't showing in the cooldown usage display.",
"Fixed a small freeze that was happening when hovering over the segments menu.",
"Fixed some slash commands not working for deDE localization.",
"Fixed Rogue Akaari's Soul not getting detected properly during combat (Flamanis).",
"Fixed the sorting columns on /keystone panel which key stone level wasn't sorting correctly (Benjamin H.).",
"Fix for Fire Elemental on Wrath (Flamanis).",
"Fixed Evoker bug where empowered abilities wasn't showing in overall data (Flamanis).",
"Fixed an error when Details! attempted to use Ghost Frame in Wrath, but Ghost frame doesn't exists on that expansion (Flamanis).",
"Fixed spec detection for some specs on retail (Flamanis).",
"Fixed ToC for Compare2, how it also works on Wrath (Flamanis).",
"Fixed an issue with buff and debuff uptime sometimes not closing properly after the combat.",


{"v10.0.2.10333.147", "Nov 18th, 2022"},
"Added two checkboxes for Merge Pet and Player spell on the Breakdown window.",
"Added uptime for Hunter's Pet Frenzy Buff, it now show in the 'Auras' tab in the Breakdown Window.",
Expand Down
6 changes: 5 additions & 1 deletion classes/class_utility.lua
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,11 @@ function _detalhes:ContainerSortMisc(container, amount, keyName2)
end
end

--[[exported]] function _detalhes:GetSpellCastAmount(combat, actorName, spellId)
---attempt to get the amount of casts of a spell
---@param combat table the combat object
---@param actorName string name of the actor
---@param spellId number spell id
function Details:GetSpellCastAmount(combat, actorName, spellId) --[[exported]]
local actorUtilityObject = combat:GetActor(4, actorName)
if (actorUtilityObject) then
local castAmountTable = actorUtilityObject.spell_cast
Expand Down
2 changes: 1 addition & 1 deletion classes/container_actors.lua
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ function Details222.Pets.AkaarisSoulOwner(petGUID)
local args = tooltipData.args

local playerGUID
--iteragfe among args and find into the value field == guid and it must have guidVal
--iterate among args and find into the value field == guid and it must have guidVal
for i = 1, #args do
local arg = args[i]
if (arg.field == "guid") then
Expand Down
4 changes: 2 additions & 2 deletions frames/window_playerbreakdown.lua
Original file line number Diff line number Diff line change
Expand Up @@ -3026,8 +3026,8 @@ function gump:CriaJanelaInfo()
for spellID, spellObject in pairs(miscActor.buff_uptime_spells._ActorTable) do
local spellName, _, spellIcon = GetSpellInfo(spellID)
if (not spellObject.uptime) then
print(_GetSpellInfo(spellID))
dumpt(spellObject)
--print(_GetSpellInfo(spellID))
--dumpt(spellObject)
end
tinsert(newAuraTable, {spellIcon, spellName, spellObject.uptime, spellObject.appliedamt, spellObject.refreshamt, spellObject.uptime/combatTime*100, spellID = spellID})
end
Expand Down
2 changes: 1 addition & 1 deletion functions/boss.lua
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ do
end)
C_Timer.After(1, function()
if (EncounterJournalSuggestTab) then
EncounterJournalSuggestTab:Click()
--EncounterJournalSuggestTab:Click()
end
end)

Expand Down
6 changes: 4 additions & 2 deletions plugins/Details_RaidCheck/Details_RaidCheck.lua
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ local CreatePluginFrames = function()
end

--create line for the scroll
local scrollCreateLine = function(self, index)
local scrollCreateLine = function(self, index) --~create
local line = CreateFrame("button", "$parentLine" .. index, self, "BackdropTemplate")
line:SetPoint("topleft", self, "topleft", 1, -((index-1) * (scrollLineHeight + 1)) - 1)
line:SetSize(scrollWidth - 2, scrollLineHeight)
Expand Down Expand Up @@ -441,9 +441,11 @@ local CreatePluginFrames = function()
elseif (playerTable.Eating) then
line.FoodIndicator.texture = eatingFoodIcon.texture
line.FoodIndicator.texcoord = eatingFoodIcon.coords
line.FoodTierIndicator.text = ""

else
line.FoodIndicator.texture = ""
line.FoodTierIndicator.text = ""
end

local flaskInfo = playerTable.Flask
Expand Down Expand Up @@ -602,7 +604,7 @@ local CreatePluginFrames = function()
end
end)

local updateRaidCheckFrame = function(self, deltaTime)
local updateRaidCheckFrame = function(self, deltaTime) --~update
raidCheckFrame.NextUpdate = raidCheckFrame.NextUpdate - deltaTime
if (raidCheckFrame.NextUpdate > 0) then
return
Expand Down

0 comments on commit da5481c

Please sign in to comment.