Skip to content

Commit

Permalink
Bug Fix
Browse files Browse the repository at this point in the history
  • Loading branch information
Tercioo committed Feb 29, 2024
1 parent 19b2556 commit e23d7f5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 16 deletions.
6 changes: 6 additions & 0 deletions classes/class_combat.lua
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,12 @@ local segmentTypeToString = {
--mythic dungeon
local bIsMythicDungeon = self:IsMythicDungeon()
if (bIsMythicDungeon) then
--check for for regular trash mythic plus segment for a quick exit
local mythicDungeonTrachInfo = self:GetMythicDungeonTrashInfo()
if (mythicDungeonTrachInfo) then
return DETAILS_SEGMENTTYPE_MYTHICDUNGEON_TRASH, DETAILS_SEGMENTTYPE_MYTHICDUNGEON
end

local mythicDungeonInfo = self:GetMythicDungeonInfo()
local bIsMythicOverallSegment, segmentID, mythicLevel, EJID, mapID, zoneName, encounterID, encounterName, startedAt, endedAt, runID = Details:UnpackMythicDungeonInfo(mythicDungeonInfo)

Expand Down
4 changes: 2 additions & 2 deletions functions/mythicdungeon/mythicdungeon.lua
Original file line number Diff line number Diff line change
Expand Up @@ -221,11 +221,11 @@ function DetailsMythicPlusFrame.EventListener.OnDetailsEvent(contextObject, even
local mythicLevel = C_ChallengeMode.GetActiveKeystoneInfo()

--just in case the combat get tagged as boss fight
Details.tabela_vigente.is_boss = nil
Details:GetCurrentCombat().is_boss = nil

--tag the combat as mythic dungeon trash
local zoneName, instanceType, difficultyID, difficultyName, maxPlayers, dynamicDifficulty, isDynamic, instanceMapID, instanceGroupSize = GetInstanceInfo()
Details.tabela_vigente.is_mythic_dungeon_trash = {
Details:GetCurrentCombat().is_mythic_dungeon_trash = {
ZoneName = zoneName,
MapID = instanceMapID,
Level = Details.MythicPlus.Level,
Expand Down
14 changes: 0 additions & 14 deletions functions/slash.lua
Original file line number Diff line number Diff line change
Expand Up @@ -1297,20 +1297,6 @@ function SlashCmdList.DETAILS (msg, editbox)
newCombat.is_trash = false
Details:Msg("done merging, segments: " .. segmentsAdded .. ", total time: " .. DetailsFramework:IntegerToTimer(totalTime))

--[[ --mythic+ debug
--tag the segment as mythic overall segment
newCombat.is_mythic_dungeon = {
MapID = _detalhes.MythicPlus.Dungeon,
StartedAt = _detalhes.MythicPlus.StartedAt, --the start of the run
EndedAt = _detalhes.MythicPlus.EndedAt, --the end of the run
SegmentID = "overall", --segment number within the dungeon
--EncounterID = encounterID,
--EncounterName = encounterName,
RunID = _detalhes.MythicPlus.RunID,
OverallSegment = true,
}
--]]

--set some data
newCombat:SetStartTime(GetTime() - totalTime)
newCombat:SetEndTime(GetTime())
Expand Down

0 comments on commit e23d7f5

Please sign in to comment.