Fix Custom Icon #706
Open
Fix Custom Icon #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Elitesparkle
commented
Mar 28, 2024
•
Elitesparkle
commented
- Bar Start After Icon now works for Overlay and Background textures too. b992b04
- Icon Size Offset is now applied immediately after login/reload. 1582c2f
This closes Tercioo#700.
This closes Tercioo#702.
Flamanis
reviewed
Mar 28, 2024
| @@ -4879,7 +4880,12 @@ function Details:InstanceRefreshRows(instance) | |||
| row.icone_classe:Show() | |||
|
|
|||
| if (start_after_icon) then | |||
| row.statusbar:SetPoint("topleft", row.icone_classe, "topright") | |||
| row.statusbar:ClearAllPoints() | |||
| row.statusbar:SetPoint("left", row.icone_classe, "right", start_after_icon_offset_x, 0) | |||
There was a problem hiding this comment.
Why an offset? This doesn't solve the issue as far as i understand.
There was a problem hiding this comment.
The offset isn't required to solve the issue. I've added it only because it looks bad to have no space between icon and bar. I've tested the changes and they work.
|
The background starting at the left of the icon is intended, as it can be used as a backdrop for the icon. |
|
Are you sure about that? With your version, people won't be able to have a background for the bar but not for the icon. With my version, people will still be able to use custom icons with built-in backdrop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.