Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Player's Selected Loot Spec In Fetched Player Info #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

srhinos
Copy link

@srhinos srhinos commented Jan 6, 2023

This should make stuff like the WA I made (here) much more capable of its job by not requiring everyone install it but instead lean on a common shared lib like this.

Overall, the data is only semi-useful to have and I'm kinda unhappy with the quality of inserting the number after the talent tables but didn't want to shift the index of stuff in the off chance the index was important to someone somewhere. Happy to make edits to clean it up a bit if wanted

@Tercioo
Copy link
Owner

Tercioo commented Mar 4, 2023

Thanks, would you mind removing the "lootSpecName"?
the value can be retrieved by getspecializationinfobyid

@srhinos
Copy link
Author

srhinos commented Mar 4, 2023

Thanks, would you mind removing the "lootSpecName"?

the value can be retrieved by getspecializationinfobyid

I added it because when no loot spec is specifically set ie your loot spec is whatever current spec is, the ID returned is 0 instead of the actual spec ID meaning that function won't actually work without extra code somewhere else.

Still worth removing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants