Add support for transmitting Rating #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When playing with my friends, we want to see what dungeon to do based on what will give the most rating. We normally have to ask each other "what's your lowest". This commit adds support to automatically communicate dungeon rating information, to power a UI like `/keys`.
This is essentially transmitting the entirety of `C_PlayerInfo.GetPlayerMythicPlusRatingSummary("player")`, with the additional ClassID information so my UI can color player names.
I've validated this code with my friends in my own addon here: https://legacy.curseforge.com/wow/addons/details-mythic-group-rating
elicwhite
commented
Oct 14, 2024
| @@ -3195,6 +3210,284 @@ openRaidLib.commHandler.RegisterComm(CONST_COMM_COOLDOWNREQUEST_PREFIX, openRaid | |||
| openRaidLib.internalCallback.RegisterCallback("onEnterGroup", openRaidLib.KeystoneInfoManager.OnPlayerEnterGroup) | |||
| openRaidLib.internalCallback.RegisterCallback("mythicDungeonEnd", openRaidLib.KeystoneInfoManager.OnMythicDungeonFinished) | |||
|
|
|||
| -------------------------------------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
I essentially copied and modified the keystones code, so the structure should be identical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing with my friends, we want to see what dungeon to do based on what will give the most rating. We normally have to ask each other "what's your lowest". This commit adds support to automatically communicate dungeon rating information, to power a UI like
/keys.This is essentially transmitting the entirety of
C_PlayerInfo.GetPlayerMythicPlusRatingSummary("player"), with the additional ClassID information so my UI can color player names.I've validated this code with my friends in my own addon here: https://legacy.curseforge.com/wow/addons/details-mythic-group-rating. The code for that addon is here: https://github.com/elicwhite/details-rating-addon/blob/main/Comms.lua
This change powers this UI from my addon (WIP)