Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - DO NOT MERGE - [#110] - Feature: Add blank translation strings for DE, ES, FR, IT, KR, BR, RU, CN, and TW. #178

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Tensounder54
Copy link

@Tensounder54 Tensounder54 commented Jul 29, 2023

WIP - DO NOT MERGE

Why

Issue #110

What

  • Adds translation variables for many strings that are not currently localiseable.
  • Fixes some spelling/grammar/formatting issues in the enUS localisation file.

Related issues:

None

Notes:

Replacement of populated strings with blank strings done using the following RegEx:
(?<!L\[|[local=])"[^\]].+["|\|](?!\)|lua_additive_table)

Replacement of populated multiline strings with blank multiline strings done using the following RegEx:
(?<=\[=\[)([^=]|\n)+

@Tensounder54
Copy link
Author

Further work needed. Marking as do not merge.

@Tensounder54 Tensounder54 changed the title [#110] - Feature - Add blank translation strings for DE, ES, FR, IT, KR, BR, RU, CN, and TW. WIP - DO NOT MERGE - [#110] - Feature: Add blank translation strings for DE, ES, FR, IT, KR, BR, RU, CN, and TW. Jul 29, 2023
@Tensounder54
Copy link
Author

Removed incorrect file changes and re-added the spelling/grammar/formatting fixes in the enUS localisation file.

@cont1nuity
Copy link
Collaborator

cont1nuity commented Jul 30, 2023

Those pseudo locales won't work within the locale system. They need to be added as full locale strings and need to be used properly in the places where they should be referenced, as they are concatenated now.

The files need to stay in the exact format to work with the CF locale system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants