Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat backend+Frontend added #16

Open
wants to merge 26 commits into
base: backend-development
Choose a base branch
from
Open

Conversation

dongjin2008
Copy link
Collaborator

@dongjin2008 dongjin2008 commented Sep 13, 2023

No description provided.

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sketchit-challenge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2023 4:57pm

# Conflicts:
#	src/app/page.tsx
#	src/app/room/[slug]/layout.tsx
#	src/app/room/[slug]/page.tsx
#	src/ui/navbar.tsx
This commit fixes the style issues introduced in 59f5198 according to the output
from Prettier and StandardJS.

Details: #16
@dongjin2008 dongjin2008 changed the title 2 functionality added Chat backend+Frontend added Sep 17, 2023
convex/openai.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjin2008 Remove all changes here

.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjin2008 Remove all changes here

package.json Outdated
@@ -15,10 +15,12 @@
"@total-typescript/ts-reset": "^0.5.1",
"clsx": "^2.0.0",
"convex": "^1.2.1",
"next": "^13.4.2",
"dotenv": "^16.3.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this dependency

import { ConvexProvider, ConvexReactClient } from "convex/react";
import * as process from "process";

const convex = new ConvexReactClient(process.env.NEXT_PUBLIC_CONVEX_URL!);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls. use the ~/env.mjs file not dotenv!!! no process.env!

const snap = useSnapshot(state);
return (
<section className="h-screen px-10 py-14 flex flex-col">
<Navbar>
Copy link
Member

@FleetAdmiralJakob FleetAdmiralJakob Sep 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the navbar component? Pls. remove the navbar component and put the logic into this file. Or you have a good reason to do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file and put the navbar into the layout. Or you have a good reason to this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this file to profile.tsx

<section className="h-screen px-10 py-14 flex flex-col">
<Navbar>
<Profile type="nav" initial={snap.user.charAt(0).toUpperCase()} />
<Profile type="nav" initial={snap.user.charAt(0).toUpperCase()} />
Copy link
Member

@FleetAdmiralJakob FleetAdmiralJakob Sep 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls. make them into buttons! Use the ~/ui/button for that

FleetAdmiralJakob and others added 2 commits September 17, 2023 14:25
This commit fixes the style issues introduced in 7e0b6c0 according to the output
from Prettier and StandardJS.

Details: #16
@socket-security
Copy link

socket-security bot commented Sep 17, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
openai 4.7.1 network, environment +0 663 kB dschnurr-openai
convex 1.2.1...1.3.1 network, environment +0/-0 40.4 MB ballingt

🚮 Removed packages: [email protected]

This commit fixes the style issues introduced in 1f49928 according to the output
from Prettier and StandardJS.

Details: #16
This commit fixes the style issues introduced in 5efd4b3 according to the output
from Prettier and StandardJS.

Details: #16
FleetAdmiralJakob and others added 2 commits September 17, 2023 16:30
This commit fixes the style issues introduced in 708358b according to the output
from Prettier and StandardJS.

Details: #16
dongjin2008 and others added 2 commits September 17, 2023 16:51
This commit fixes the style issues introduced in a95dd39 according to the output
from Prettier and StandardJS.

Details: #16
dongjin2008 and others added 3 commits September 17, 2023 16:56
This commit fixes the style issues introduced in c715186 according to the output
from Prettier and StandardJS.

Details: #16
FleetAdmiralJakob and others added 2 commits September 17, 2023 18:55
# Conflicts:
#	package.json
#	pnpm-lock.yaml
#	src/app/layout.tsx
This commit fixes the style issues introduced in 88ef5ea according to the output
from Prettier and StandardJS.

Details: #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants