Add, fix and improve licenses #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the short indentifier for the Boost Software Licens - Version 1.0. The new identifier correponds to the SPDX short identifier. The source of this identifier is the [Open Source Initiative](https://opensource.org/licenses/BSL-1.0).
Three new licenses are added in this commit: MIT-0, LGPLv2.1, APSL-2.0. The short name for these licenses corresponds to their SPDX identifier, except for LGPLV2.1. The logn name is similar to the closest license, for example LGPLv3 for LGPLv2.1. The source of these lincenses is [Open Source Initiative](https://opensource.org/licenses/alphabetical).
Added the link to the [Open Source Initiative](https://opensource.org/licenses/) license list next to choosealicense.com. Like choosealicense.com, it is added as comment on top of LICENSES declaration. The information of the licenses was extracted from the alphabetical ordered list, although a more generic link is provided here.
Two new licenses are added in this commit: AFL-3.0, APL-1.0. The short name for these licenses corresponds to their SPDX identifier. The long name is similar to the closest licenses. The source of these lincenses is [Open Source Initiative](https://opensource.org/licenses/alphabetical).
All licenses identifier is now set to their SPDX identifier. These identifiers have been collected from the [Open Source Initiative](https://opensource.org/licenses/alphabetical).
Fixed a small error in the Swift comment in the file extension colors.
This commit fixes an error caused by a missing comma in the licenses list. The error was caused in line 37 after the LGPL-2.1 license.
Updated all added licenses starting text to the actual first part of the license text. See issue The-Noah#27 for background on this commit.
After using the SPDX website as source of licenses texts, it is now added to licenses sources. The website offers a long list of licenses, with their SPDX identifier and full text.
Licenses are ordered by alphabet order in this commit, following their SPDX identifier. A small error in APSL-2.0 was fixed, as the S was missing.
Simply adds two lines of comments indicating how the LICENSES list works. It indicates what are the strings in each license and how they are ordered.
The-Noah
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
This PR is the first of many PRs about licenses. This first one adds many licenses, reorders them, makes the switch to SPDX identifiers and fixes some other issues.
Other than licenses, a small typo was fixed in the colors of file extensions, specifically in the Swift language.
New license naming standard
The way licenses are registered is now as discussed in issue #27. They are now identified by their corresponding SPDX identifier, that is the first string in a license item in the list. They have also been reordered, following an alphabetical order based on the SPDX identifier.
Licenses added
Below are listed the licenses added in this PR, more are to be added in other PRs.
By any means this list is complete, and more work will be put into license registration in the future.
Issues related
Resolves #27 and contributes to #7.
Documentation on licenses
The sources used for the expansion of the list are cited as comments below the choosealicense.com one. These sources are the Open Source Initiative (for licenses and their SPDX identifiers) and the official SPDX webpage (for the full license text).
In addition to the sources, two lien comments have been added. These comments simply add a little bit of documentation about how the LICENSE list is structured, stating how it is ordered and what each string means. These comments were put in place to help future contributors better understand how to contribute to this license.