Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed changes to diagram #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atjessehill
Copy link

I've created a fork using a different design that puts production in a central role to coordinate the calls between the different modules.

Moving away from the previous waterfall-like pipeline allows the user to interact more flexibly with the application. Such as when a user wishes to re-record their voice input without triggering the whole pipeline which could take upwards of 30 seconds on slower systems. Also giving production access to TTS's output will allow us to set the sliders to a specific position.

image

@wassfila
Copy link
Member

  • I corrected the Production content the way you see it, thanks for that, for practicality, I'll rather review the changes and cherry pick their application instead of automated merge
  • with regard to the feedback STT -> Prod : It is not possible to handle a text string directly to apply a control, you would need an engine similar to the TTS group, which has not been planned so far, otherwise I'd like to have more details about that path, it does not look realistic with direct connection, otherwise provide example of sentences of text and how you would handle them on your pipeline
  • for the audio data, I do not agree with fragmenting audio samples over websocket, I'll discuss with SG group to have the simplest IF, why is a POST not considered ? which does not need fragmentation ?
  • Also the dependency TTS -> SG was planned since the beginning, I would have to verify with Valerio why would we modify the path. That Production has a GUI is good, but it was not intended to become a Monolith of the whole logic inside it

@wassfila
Copy link
Member

updated the diagram with a0b00fa
https://thesoundofaiosr.github.io/docs/resources/design/

We still have open points to clarify, I'll initiate a chat

@wassfila
Copy link
Member

I will try for visibility purpose to keep data flow separate in two gray boxes when it vehiculates information in two direction, the double arrow would only be combined for request and its back acknowledge.
This might be a bit confusing as it is not strict UML rather free drawing I'll try to sort things out as soon as we agree on the model.

@wassfila
Copy link
Member

So to be fair with the idea and give it all its chances, I branched it in a separate document 'overview_alt.graphml' so that we can see them side by side.
https://github.com/TheSoundOfAIOSR/website/tree/main/static/design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants