Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pagination to DiscoverDetailScreen #1108

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

add pagination to DiscoverDetailScreen #1108

wants to merge 3 commits into from

Conversation

Richie911
Copy link
Contributor

Description

This PR tackles the enhancement request "Paginate discover details data"

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2024

@Richie911 is attempting to deploy a commit to the Streamability Team on Vercel.

A member of the Team first needs to authorize it.

@Richie911 Richie911 force-pushed the 838-paginate-discover-details-data branch 2 times, most recently from 7569c93 to 0ca1d7c Compare December 26, 2024 01:09
@Richie911 Richie911 force-pushed the 838-paginate-discover-details-data branch from 0ca1d7c to be449cb Compare December 26, 2024 22:27
@vercel Vercel
Copy link

vercel bot commented Jan 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
streamability ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 3:37am

@Thenlie
Copy link
Owner

Thenlie commented Jan 21, 2025

If I understand this correctly, this PR does not actually paginate the discover details request. Instead, it just breaks up the pre-existing data into pages. With this approach, we do not get any performance benefits as all the data must be fetched before the UI can be rendered. If we have all the data, we should not make the user wait for it to be displayed.

Instead, we should paginate the actual request. I believe https://github.com/Thenlie/Streamability/blob/main/src/hooks/usePaginatedData.ts can be used to accomplish this. Let me know if you have any specific questions here, happy to try and help!

@Thenlie Thenlie linked an issue Jan 21, 2025 that may be closed by this pull request
🏗 Paginate discover details data #838
Open
@Thenlie Thenlie added the type: enhancement Update of existing code label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Richie911 Richie911

Labels
type: enhancement Update of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🏗 Paginate discover details data
2 participants
@Richie911 @Thenlie