Add more helpful error message for UnnamedIndexLevelsException #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibTrip
reviewed
Dec 3, 2023
pangres/engine.py
Outdated
| @@ -127,7 +127,7 @@ def __init__(self, | |||
| # all index levels have names | |||
| index_names = list(df.index.names) | |||
| if any(ix_name is None for ix_name in index_names): | |||
| raise UnnamedIndexLevelsException("All index levels must be named!") | |||
| raise UnnamedIndexLevelsException("All index levels must be named! Ensure you used `df = df.set_index(['col1', 'col2', ...])` before.") | |||
There was a problem hiding this comment.
Hey, that looks good but the line is too long (must be <= 120 characters), so I suggest doing so:
Suggested change
| raise UnnamedIndexLevelsException("All index levels must be named! Ensure you used `df = df.set_index(['col1', 'col2', ...])` before.") | |
| raise UnnamedIndexLevelsException("All index levels must be named! " | |
| "Ensure you used `df = df.set_index(['col1', 'col2', ...])` before.") |
ThibTrip
reviewed
Dec 3, 2023
pangres/utils.py
Outdated
| @@ -88,7 +88,7 @@ def fix_psycopg2_bad_cols(df: pd.DataFrame, replacements: dict = {'%': '', '(': | |||
| # verify all index levels are named | |||
| index_names = list(df.index.names) | |||
| if any([ix_name is None for ix_name in index_names]): | |||
| raise UnnamedIndexLevelsException("All index levels must be named!") | |||
| raise UnnamedIndexLevelsException("All index levels must be named! Ensure you used `df = df.set_index(['col1', 'col2', ...])` before.") | |||
There was a problem hiding this comment.
Same comment as for the other file :)
Suggested change
| raise UnnamedIndexLevelsException("All index levels must be named! Ensure you used `df = df.set_index(['col1', 'col2', ...])` before.") | |
| raise UnnamedIndexLevelsException("All index levels must be named! " | |
| "Ensure you used `df = df.set_index(['col1', 'col2', ...])` before.") |
ThibTrip
requested changes
Dec 3, 2023
|
Updated, should be good now! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.