This repository has been archived by the owner on Dec 5, 2021. It is now read-only.
Fix 96 target static duplicate meta tags #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also extend all route-tests to count number of occurrences for no-content meta tags, e.g. `charset` rel: TiagoDanin#96
also update `test/fixtures/all.js` accordingly rel: TiagoDanin#96
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #96
Added proposed "fix": no-content meta tags get the attribute 'hid' set
Updated existing tests to fit new generated sources.
Added additional test for SSR served sources to check for duplicate no-content meta tags (there were non - SSR seems not to have suffered from this issue)
Added new test to also test static generated sources for duplicate no-content meta tags.
In addition I refactored the
generatefunction a little to keep it DRY.PS: many thanks for this plugin. Makes SEO a breeze