Initial typography settings #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksin
commented
Feb 1, 2017
index.css
Outdated
| } | ||
|
|
||
| html, body { | ||
| color: var(--base-font-color); |
There was a problem hiding this comment.
Not sure if base color should be defined with typography settings, but I also think it will be very useful.
ksin
commented
Feb 1, 2017
index.css
Outdated
| h5 { font-weight: bold; font-size: 0.875rem; } /* 14px */ | ||
|
|
||
| /** | ||
| * Body Text |
There was a problem hiding this comment.
Missing "Meta Text" from the design spec, which should be 12px (0.75rem). Suggestions on which HTML element this belongs to?
ksin
force-pushed
the
initial-typography-settings
branch
from
70b2aeb to
e570bd6
Compare
spencer516
reviewed
Feb 1, 2017
index.css
Outdated
| @font-face { | ||
| font-family: "Gibson"; | ||
| font-weight: 900; | ||
| src: url("https://static.ticketfly.com/fonts/gibson/webfonts/2E3C08_3_0.eot"); |
There was a problem hiding this comment.
We'll probably want to do something so that the url that this is pointing at is configurable. (If for whatever reason, a third party chose to use this, we wouldn't want their site using our fonts).
I don't have a solution in mind, but food for thought. :)
ksin
force-pushed
the
initial-typography-settings
branch
from
e570bd6 to
6520857
Compare
ksin
force-pushed
the
initial-typography-settings
branch
from
6520857 to
984ce9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BrianSipple @melissaroman @spencer516
Basically follows the design spec.
I don't like how the font-faces are imported in this file right now, but just wanted to get everything up in one place for folks to look at and comment on. Suggestions on where to place them would be good.
Also see comments below.