Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: numerous improvements to past event fetching #154

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: numerous improvements to past event fetching #154

merged 1 commit into from
Nov 27, 2024

Conversation

PurkkaKoodari
Copy link
Member

  • add proper tests
  • fix broken date condition in getEventDetails
  • fix broken merging of wheres with scope
  • clean up getEventList where building code
  • change to simpler manual cache key normalization
  • make hard event age cutoff configurable

@PurkkaKoodari
fix: numerous improvements to past event fetching
0e216c1 
- add proper tests
- fix broken date condition in getEventDetails
- fix broken merging of `where`s with scope
- clean up getEventList `where` building code
- change to simpler manual cache key normalization
- make hard event age cutoff configurable
@PurkkaKoodari PurkkaKoodari requested a review from a team November 27, 2024 16:09
@PurkkaKoodari PurkkaKoodari merged commit b4bda48 into dev Nov 27, 2024
3 checks passed
@PurkkaKoodari PurkkaKoodari deleted the fix/past-events-fixes branch November 27, 2024 18:03
@PurkkaKoodari PurkkaKoodari mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatanaatos joonatanaatos joonatanaatos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PurkkaKoodari @joonatanaatos