Fix ambiguous capsule calls with pybind11 #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks correct to me, but I swear we already made these changes before to fix these errors. Maybe it was in different files, or maybe even in the TileDB-SOMA Pybind11 code. I want to check again tomorrow morning. For now, can you please run |
|
@nguyenv I saw a fix related in a SOMA pybind11 PR, I'll update formatting in a bit, thanks. |
johnkerl
changed the title
ihnorton
approved these changes
Jan 15, 2024
|
Thanks @robertbindar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got multiple errors like this:
error: call of overloaded ‘capsule(std::__shared_ptr<tiledb_subarray_t, __gnu_cxx::_S_atomic>::element_type*, const char [9], std::nullptr_t)’ is ambiguouswhen building fresh with latest pybind on ubuntu22,
m6id.4xlargeec2 machine.Not sure this is the correct fix, just fixed all the errors to get myself a successful build and thought effort shouldn't go to waste in case it's the correct approach.