Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe repr for Group #1890

Merged

Conversation

nguyenv
Copy link
Collaborator

@nguyenv nguyenv commented Jan 18, 2024

See #1545 for a full explanation. This just needed to be added for the Group class as well.

Copy link

This pull request has been linked to Shortcut Story #39303: Use Safe repr If Group Pybind11 Constructor Fails.

@nguyenv nguyenv force-pushed the viviannguyen/sc-39303/use-safe-repr-if-group-pybind11-constructor branch from d75bc36 to 3d5c636 Compare January 18, 2024 22:33
Copy link

@jparismorgan jparismorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I would wait for another approve though, as I don't know this code well.

@nguyenv nguyenv merged commit 3221954 into dev Jan 19, 2024
32 of 34 checks passed
@nguyenv nguyenv deleted the viviannguyen/sc-39303/use-safe-repr-if-group-pybind11-constructor branch January 19, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants