Fix view_attr not being respected by __getitem__ and subarray
#2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
force-pushed
the
agis/respect-view_attr
branch
from
594b747 to
ab4ac0a
Compare
kounelisagis
changed the title
Query to respect view_attrview_attr not being respected by __getitem__ and subarray
ihnorton
approved these changes
Jan 23, 2025
Co-authored-by: nguyenv <[email protected]>
Co-authored-by: nguyenv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
attrargument in theArray.openmethod (internally stored asview_attr) was not respected during query operations. Consequently, theArray.querymethod ignored the specified attribute(s) and returned all attributes instead. The issue has been resolved by updating the__getitem__andsubarraymethods of both Sparse and Dense Arrays.[sc-61659]