Skip to content

Commit

Permalink
Clarifications and adaptation of result tile sizes
Browse files Browse the repository at this point in the history
  • Loading branch information
ypatia committed Jan 13, 2025
1 parent 8ffa2cf commit 9e7915b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions test/src/unit-cppapi-consolidation-with-timestamps.cc
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ TEST_CASE_METHOD(

// Will only allow to load two tiles out of 3.
Config cfg;
cfg.set("sm.mem.total_budget", "65000");
cfg.set("sm.mem.total_budget", "50000");
cfg.set("sm.mem.reader.sparse_global_order.ratio_coords", "0.15");
ctx_ = Context(cfg);

Expand Down Expand Up @@ -685,7 +685,7 @@ TEST_CASE_METHOD(

// Will only allow to load two tiles out of 3.
Config cfg;
cfg.set("sm.mem.total_budget", "60000");
cfg.set("sm.mem.total_budget", "50000");
cfg.set("sm.mem.reader.sparse_global_order.ratio_coords", "0.15");
ctx_ = Context(cfg);

Expand Down
16 changes: 8 additions & 8 deletions test/src/unit-sparse-global-order-reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ TEST_CASE_METHOD(

// Specific relationship for failure not known, but these values
// will result in failure with data being written.
total_budget_ = "30000";
total_budget_ = "10000";
// Failure here occurs with the value of 0.1 for ratio_tile_ranges_.
update_config();

Expand Down Expand Up @@ -653,7 +653,7 @@ TEST_CASE_METHOD(

// specific relationship for failure not known, but these values
// will result in failure with data being written.
total_budget_ = "40000";
total_budget_ = "15000";
// Failure here occurs with the value of 0.1 for ratio_tile_ranges_.
update_config();

Expand Down Expand Up @@ -789,9 +789,9 @@ TEST_CASE_METHOD(
write_1d_fragment(coords, &coords_size, data, &data_size);
}

// Two result tiles (2 * (~4500 + 8) will be bigger than the per fragment
// budget (3905).
total_budget_ = "82000";
// Two result tiles (2 * (3216 + 8) will be bigger than the per fragment
// budget (3300).
total_budget_ = "60000";
ratio_coords_ = "0.11";
update_config();

Expand Down Expand Up @@ -1312,9 +1312,9 @@ TEST_CASE_METHOD(
write_1d_fragment(coords, &coords_size, data, &data_size);
}

// Two result tile (2 * (~4500 + 8) will be bigger than the per fragment
// budget (1000).
total_budget_ = "45000";
// Two result tile (2 * (3216 + 8) will be bigger than the per fragment
// budget (4400).
total_budget_ = "40000";
ratio_coords_ = "0.22";
update_config();

Expand Down

0 comments on commit 9e7915b

Please sign in to comment.