Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation generation and source formatting into dedicated CMake modules. #4538

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

teo-tsirpanis
Copy link
Member

SC-36914


TYPE: BUILD
DESC: Move documentation generation and source formatting into dedicated CMake modules.

Copy link

This pull request has been linked to Shortcut Story #36914: Move the doc target from the superbuild to the main build.

@teo-tsirpanis
Copy link
Member Author

The generated HTML documents seem OK upon manual inspection. This is ready for review.

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review November 25, 2023 01:21
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment inline.

Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good.

  • Need to remove change to workflow that should be the content of different PR.
  • Small code organization point.

CMakeLists.txt Outdated Show resolved Hide resolved
.github/workflows/build-docs.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@eric-hughes-tiledb eric-hughes-tiledb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KiterLuc KiterLuc merged commit df88a4b into TileDB-Inc:dev Nov 30, 2023
60 checks passed
@teo-tsirpanis teo-tsirpanis deleted the doc-format-module branch November 30, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants