-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move documentation generation and source formatting into dedicated CMake modules. #4538
Conversation
This pull request has been linked to Shortcut Story #36914: Move the |
`DOXYGEN_EXECUTABLE` is deprecated since CMake 3.9.
…erbuild. We cannot forward to the main build, it might have not been built yet.
836ffa5
to
82e6af0
Compare
The generated HTML documents seem OK upon manual inspection. This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the comment inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good.
- Need to remove change to workflow that should be the content of different PR.
- Small code organization point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SC-36914
TYPE: BUILD
DESC: Move documentation generation and source formatting into dedicated CMake modules.