Add constexpr for Filesystem support #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #37703: Define |
eric-hughes-tiledb
suggested changes
Nov 29, 2023
eric-hughes-tiledb
suggested changes
Nov 30, 2023
eric-hughes-tiledb
approved these changes
Dec 1, 2023
ypatia
pushed a commit
that referenced
this pull request
Dec 6, 2023
One step toward `VFS` and `tiledb_unit` cleanup. In `vfs.h`, add `constexpr` to represent whether or not a filesystem is supported. Additionally, do some miscellaneous, related cleanup. --- TYPE: IMPROVEMENT DESC: Use constexpr to check for filesystem support
| get_supported_fs( | ||
| &supports_s3, &supports_hdfs, &supports_azure, &supports_gcs); | ||
| if (supports_s3) { | ||
| if constexpr (tiledb::sm::filesystem::s3_enabled) { |
There was a problem hiding this comment.
This has caused the cloud VFSes to be initialized even when I pass --vfs native, if TileDB is compiled with the cloud VFSes enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step toward
VFSandtiledb_unitcleanup. Invfs.h, addconstexprto represent whether or not a filesystem is supported. Additionally, do some miscellaneous, related cleanup.TYPE: IMPROVEMENT
DESC: Use constexpr to check for filesystem support