Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't close connection in management command #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olivierdalang
Copy link

This removes close_old_connections() at the end of the management command, because this prevents using call_command in the context of tests :

from django.core.management import call_command
from django.test import TestCase

class MyTestCase(TestCase):
    def test_cron(self):
        ...
        call_command('runcrons')
        # test something else here
        ...

This fails with psycopg2.InterfaceError: connection already closed, as tests are run in transaction and django needs to rollback the transaction at the end of the test.

The close_old_connections() line was added in f7de420 back in 2013, I'm pretty sure in the mean time it's become useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant