Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide distinct server code with placement code #30

Merged
merged 1 commit into from
May 11, 2021
Merged

feat: provide distinct server code with placement code #30

merged 1 commit into from
May 11, 2021

Conversation

timoknapp
Copy link
Contributor

Since placement codes do actually relate to the servers and not to locations (#5) I extended the current config such that you can also provide the server code from which the placement code has been issued. This can be done by providing the related server code in parentheses like the following:

locations = 69123 Heidelberg[XXXX-XXXX-XXXX](XXX)

The big advantage of this is, that you can now use your placement code in every location you want to use them for. So lets assume you have a code generated from server 001-iz.impfterminservice.de and location 69124 Heidelberg but you want to use this code for the location 69123 Heidelberg which actually works with server 002-iz.impfterminservice.de. In order to do that you simply need to provide the code (001) in parentheses behind the placement code: 69123 Heidelberg[XXXX-XXXX-XXXX](001). With this config the impf-bot will directly go to the correct server and enter the corresponding placement code accordingly.

Regards Timo

@TobseF
Copy link
Owner

TobseF commented May 11, 2021

Great addition, tank you 👍 Hope you enjoyed the time with Kotlin😉

To check a lot of locations, this makes the locations config even longer and hard to maintain. To make it more user friendly, it would be a good time to separate the a location list.

@TobseF TobseF merged commit 3ac48d4 into TobseF:master May 11, 2021
@timoknapp
Copy link
Contributor Author

Hi @TobseF ,

sure! But I am actually quite familiar with Kotlin, since I am writing Spring microservices with Kotlin the whole day 😄
You are right, lets see if I can find some time to create a new PR with the refactor.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants