GHA to update jib image with the latest version #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alathreon
requested changes
Sep 28, 2024
| git config --global user.name "github-actions[bot]" | ||
| git config --global user.email "github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| branch_name="update-eclipse-temurin-$latest_version" |
There was a problem hiding this comment.
Find a better name like "JShell Java Version" or "Session Java Version".
| git checkout -b "$branch_name" | ||
|
|
||
| git add "$gradle_file" | ||
| git commit -m "Update eclipse-temurin version to $latest_version" |
There was a problem hiding this comment.
Find a better name like "Update JShell to Java 23".
| git rebase origin/develop | ||
| git push origin "$branch_name" | ||
|
|
||
| gh pr create --title "Update eclipse-temurin version to $latest_version" \ |
There was a problem hiding this comment.
Find a better name like "Update JShell to Java 23".
| git push origin "$branch_name" | ||
|
|
||
| gh pr create --title "Update eclipse-temurin version to $latest_version" \ | ||
| --body "This PR updates the eclipse-temurin version in the JShellAPI build.gradle file from $current_version to $latest_version." \ |
There was a problem hiding this comment.
Don't specify eclipse temurin since that's not what matters. And it's not JShellAPI but JShellWrapper.
Also since it's markdown, a link could be used to link to the build.gradle.
|
Closed since a new duplicate PR will replace it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR was a request from Alatheron to auto update the jib docker image when a new update is available.
How this works:
Screenshots
