Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with addons like NoAutoClose #96

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Numynum
Copy link
Contributor

@Numynum Numynum commented Sep 11, 2024

NoAutoClose (and similar addons) make UIPanelWindows[frameName] nil, which breaks showing/hiding default frames, and can also cause errors when toggling the setting
Changing parent regardless, and checking whether framesUILayoutEngineSettings[frameName] is non-nil, fixes these issues

Copy link
Member

@Solanya Solanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@Solanya Solanya merged commit fc95de0 into Total-RP:main Sep 11, 2024
1 check failed
@Numynum Numynum deleted the patch-1 branch September 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants