Make icon searching asynchronous #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the icon browser and its search functionality to be an asynchronous process that'll step in smaller incremental steps whenever the filter text is changed. The visual design of the icon browser is mostly unaltered with the exception of a new progress bar to display the search progress.
Solanya
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the icon browser and its search functionality to be an asynchronous process that'll perform the search in small incremental steps whenever the filter text is changed.
The visual design of the icon browser is mostly unaltered with the exception of a new progress bar to display the search progress.
WowT_i1WoVTSqWv.mp4
With this change we no longer need to iterate over the entire icon list provided by LRPM at all on addon load, which should resolve the few reports of script timeouts in that area. Currently the searching is quite conservative and only tests 500 icons per frame, which feels fast enough for the most part and seemingly has no measurable impact on framerate.