Patch 10.2.7 compatibility #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably just ancient merge damage - these three files are loaded in the same XML file just a few lines up.
Unlike the pet browser, this needs to be classic-compatible.
This is being removed in 11.0.0. One call remains as it's a bit hairy to migrate and I need to understand what it's actually doing a bit more. Also need to accomodate Extended which does one similar call to these.
The non-namespaced variants are deprecated and will be removed in 11.0. We've held off removing the old usages because Wrath didn't have all the C_AddOns variants, but this is no longer the case in Cataclysm.
Similar story; will be removed in 11.0 and Cataclysm now has these.
Only one usage in this namespace needs migrating. This function is removed in 11.0, and is present in Cataclysm already.
Non-namespaced UnitAura is dead in 11.0, with the replacement now available in Cataclysm. This is a bit more complex a migration because it returns a structured table now, unlike all the others. Additionally - fixed an improper initialization of the current mount spell ID in Classic.
As Classic won't get this change for a while, we can fold this into 10.2.7 as having a backward compatible path is forced upon us.
This hasn't been needed since patch 3.4.3 went live.
Size and Offset elements have supported inline absolute attributes for a long time now. Let's do a quick batch cleanup...
These also support inline absolute attributes.
Meorawr
force-pushed
the
patch/10.2.7-compat
branch
from
d62db95 to
b5c7df9
Compare
Solanya
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc. tweaks so that we don't blow up horribly on patch day.
Note that the changes to the pet browser aren't compatible with live clients, so don't merge this until we're happy that the next release we make will be for 10.2.7.