Implement copy/pasting of glance traits #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is provided as part of the right-click menu. While another ticket does suggest the use of Ctrl-Click for the copy operation, there's the question of how do you then paste it - a button could be added to the editor instead, but this approach feels fine (I mean, /everything/ lets you right-click for copy and paste normally, right?). A lot of this would benefit from a better dropdown system, as the current implementation relies on the glance buttons having global names to perform the copy at least.
Flag sets apply to glances, not presets...
|
Did some additional testing; confirmed that presets aren't broken with the dropdown changes and verified that I can copy another user's companion glances onto my own just fine. |
Ellypse
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37. Tested with my own profile and companions, as well as copying from profiles in the register. Unfortunately trying to find someone ingame right now with a companion profile is proving impossible, so haven't tested copying another persons companion traits.
This is provided as part of the right-click menu. While another ticket (#63) does suggest the use of Ctrl-Click for the copy operation, there's the question of how do you then paste it. A button could be added to the editor instead, but this approach feels fine (I mean, everything lets you right-click for copy and paste normally, right?).
A lot of this would benefit from a better dropdown system, as the current implementation relies on the glance buttons having global names to perform the copy at least.