Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2: [LILA-5502] Remove functionality to hold funds in the OffsetHelper #21

Merged
merged 1 commit into from
Oct 2, 2023
Merged

P2: [LILA-5502] Remove functionality to hold funds in the OffsetHelper #21

merged 1 commit into from
Oct 2, 2023

Conversation

GigaHierz
Copy link
Contributor

@GigaHierz GigaHierz commented Sep 21, 2023 •
edited
Loading

Closes #14

@toucan-robot toucan-robot changed the title [LILA-5502]-remove-functionality-to-hold-funds-in-OffsetHelper P2: [LILA-5502]-remove-functionality-to-hold-funds-in-OffsetHelper Sep 21, 2023
@GigaHierz GigaHierz changed the title P2: [LILA-5502]-remove-functionality-to-hold-funds-in-OffsetHelper P2: [LILA-5502] Remove functionality to hold funds in the OffsetHelper Sep 21, 2023
0xmichalis
0xmichalis reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@0xmichalis 0xmichalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it needs a rebase

refactor: remove balances variable, remove withdraw and deposit funct…
390d210 
…ion, as contract shouldn't be able to hold funds
@GigaHierz GigaHierz force-pushed the LILA-5502/remove-functionality-to-hold-funds-from-offsethelper branch from 00968a4 to 390d210 Compare October 2, 2023 14:09
0xmichalis
0xmichalis approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@0xmichalis 0xmichalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the redeemAuto comment can be addressed in a separate PR.

@GigaHierz GigaHierz merged commit af92bbf into ToucanProtocol:main Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmichalis 0xmichalis 0xmichalis approved these changes

Assignees
No one assigned
Labels
priority/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace using balances with IERC20.balanceOf
3 participants
@GigaHierz @0xmichalis @toucan-robot