Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Fix issues of autoclosing single and double quotes when using certain color schemes #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivang
Copy link

@ivang ivang commented Sep 7, 2015

If the used color scheme redefines the 'String' or 'Character' syntax regions, autoclosing single and double quotes stops working (see issues #43, #45, #55, and #64) . This PR fixes this problem and supposedly solve the issues mentioned.

(Anyway, why would you disable autoclosing in strings?)

@ivang ivang changed the title Fix autoclose issues with certain color schemes and syntax files Fix issues of autoclosing single and double quotes when using certain color schemes Sep 7, 2015
timss added a commit to timss/vimconf that referenced this pull request Nov 20, 2015
* In certain syntax regions (string, character), matching autoclose pairs
  "" or '' doesn't work as intended.
* Original maintainer has stopped accepting PRs, opt for using fork.
  For more information, see Townk/vim-autoclose#67
@timss
Copy link

timss commented Nov 20, 2015

Thanks, this bug had eluded me for some time.

somini added a commit to somini/vim-autoclose that referenced this pull request Mar 13, 2016
@somini
Copy link

somini commented Mar 13, 2016

Many thanks for this, it was driving me nuts.

I've merged this PR on my fork.
https://github.com/somini/vim-autoclose

@timss
Copy link

timss commented Mar 13, 2016

Cool, thanks for merging other PRs as well @somini

@somini There's actually a lot of other commits that haven't been added as PRs though. You can find them using the network overview:

https://github.com/Townk/vim-autoclose/network

Haven't looked through all of them, but might want to add some of them to your fork as well?

@somini
Copy link

somini commented Mar 13, 2016

Yeah, I looked at those too, most are just overriding the default pairs setting instead of adding a line to vimrc. :S
I haven't looked at all, and there's also many issues that need triage.

@timss
Copy link

timss commented Mar 13, 2016

Ah, sounds like you got it under control! 👍

After confirming it works with the rest of my setup/plugins I'll be sure to change to your fork in my vimconf.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants