Skip to content

Commit

Permalink
Merge pull request wowsims#431 from wowsims/tharre/warlock-fixes
Browse files Browse the repository at this point in the history
warlock: fix broken imp GCD emulation
Tharre authored May 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2 parents 850388c + 5cf7309 commit 986b6c9
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions sim/warlock/pets.go
Original file line number Diff line number Diff line change
@@ -351,15 +351,15 @@ func (pet *WarlockPet) registerFireboltSpell() {

ManaCost: core.ManaCostOptions{BaseCost: 0.02},
Cast: core.CastConfig{
CD: core.Cooldown{
// emulate the imp 1.5s GCD that does not change with haste
Timer: pet.NewTimer(),
Duration: 1500 * time.Millisecond,
},
DefaultCast: core.Cast{
GCD: core.GCDDefault,
CastTime: 2500 * time.Millisecond,
},
IgnoreHaste: true,
// Custom modify cast to not lower GCD
ModifyCast: func(sim *core.Simulation, spell *core.Spell, cast *core.Cast) {
cast.CastTime = spell.Unit.ApplyCastSpeedForSpell(spell.DefaultCast.CastTime, spell)
},
},

DamageMultiplier: 1,

0 comments on commit 986b6c9

Please sign in to comment.