Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Calender icon RTL not supported #997

Closed
1 task
mehmetranas opened this issue Jan 28, 2025 · 1 comment · Fixed by #998
Closed
1 task

[BUG]: Calender icon RTL not supported #997

mehmetranas opened this issue Jan 28, 2025 · 1 comment · Fixed by #998
Labels
bug Something isn't working

Comments

@mehmetranas
Copy link
Contributor

Issue description

Steps to Reproduce:

Open the date picker component.

Add RTL direction to the document (e.g., ).

Observe the calendar icon and navigation arrows.

Expected Behavior:

The calendar icon and navigation arrows should adjust their positions to align with RTL conventions (e.g., the left and right arrows should not be swapped).

Actual Behavior:

The calendar icon and navigation arrows remain in their original positions, which is inconsistent with RTL layouts.

Additional Information:

This issue likely affects usability for RTL language users.

A fix should ensure that the icon and arrows respect the dir="rtl" attribute.

Media & Screenshots

No response

Baklava Version

3.3.0-beta.15

Operating system

  • OS: [e.g. iOS]:

  • Browser [e.g. chrome, safari]:

  • Any other details...

Priority this issue should have

Low (slightly annoying)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@mehmetranas mehmetranas added the bug Something isn't working label Jan 28, 2025
@mehmetranas
Copy link
Contributor Author

I’m working on a fix for this and will submit a pull request shortly.

buseselvi pushed a commit that referenced this issue Jan 31, 2025
#998)

Issue
When the user selects RTL mode, the calendar icons are swapped
incorrectly.

Fix
Explicitly set direction: ltr to ensure icons remain in the correct
order.
Resolved incorrect icon placement while maintaining RTL layout.

Issue: #997

---------

Co-authored-by: mehmet.tanas <[email protected]>
Co-authored-by: Erbil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant