Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bl-calendar): Add RTL support for arrow icons to prevent visual s… #998

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

mehmetranas
Copy link
Contributor

@mehmetranas mehmetranas commented Jan 29, 2025

Issue
When the user selects RTL mode, the calendar icons are swapped incorrectly.

Fix
Explicitly set direction: ltr to ensure icons remain in the correct order.
Resolved incorrect icon placement while maintaining RTL layout.

Issue: #997

@AykutSarac AykutSarac requested a review from a team January 30, 2025 08:04
@AykutSarac AykutSarac linked an issue Jan 30, 2025 that may be closed by this pull request
1 task
@erbilnas
Copy link
Collaborator

Hi @mehmetranas, I reviewed the changes in the playground, but I didn't observe any differences. Does this work for you?

@mehmetranas
Copy link
Contributor Author

Thanks @erbilnas for your notice! I’ve updated the RTL support logic—could you check again?

mehmet.tanas and others added 3 commits January 30, 2025 13:49
@buseselvi buseselvi merged commit ef5cc6f into Trendyol:next Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Calender icon RTL not supported
3 participants