Skip to content

Commit

Permalink
fix: revert improve type safety in retargeting proxy setter (#930)
Browse files Browse the repository at this point in the history
* Revert "fix: improve type safety in retargeting proxy setter"

This reverts commit 6d8e742.

* refactor(createRetargetingProxy): remove unneeded Partial type from setters arg

---------

Co-authored-by: Peter <[email protected]>
  • Loading branch information
alvarosabu and andretchen0 authored Feb 11, 2025
1 parent 9e76010 commit 0a95764
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/utils/primitive/createRetargetingProxy.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export function createRetargetingProxy<T extends Record<string | number | symbol, any>, K extends keyof T & string & symbol>(
target: T,
getters = {} as Record<string | number | symbol, (t: T) => unknown>,
setters = {} as Partial<Record<K, (val: T[K], t: T, proxy: T, setTarget: (newTarget: T) => void) => boolean>>,
setters = {} as Record<K, (val: T[K], t: T, proxy: T, setTarget: (newTarget: T) => void) => boolean>,
) {
let _target = target

Expand All @@ -22,9 +22,8 @@ export function createRetargetingProxy<T extends Record<string | number | symbol
return _target[prop]
},
set(_: any, prop: K, val: T[K]) {
const setter = setters[prop]
if (setter && typeof setter === 'function') {
setter(val, _target, proxy, setTarget)
if (setters[prop]) {
setters[prop](val, _target, proxy, setTarget)
}
else {
_target[prop] = val
Expand Down

0 comments on commit 0a95764

Please sign in to comment.