Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed win32 checkpoint resume SEGFAULT #8412

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fixed win32 checkpoint resume SEGFAULT #8412

merged 1 commit into from
Jan 27, 2025

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Jan 24, 2025 •
edited
Loading

Fixes #8353

This PR:

  • Fixes a libtorrent SEGFAULT if resume_data does not include save_path on win32.

The new strategy is this:

  1. Attempt to decode the existing resume_data, if this fails remove all the resume_data.
  2. If we have valid resume_data and the save_path is not set, inject it based on the save_path of the ATP dict.

@qstokkink qstokkink force-pushed the fix_32bitwin_save_path branch 3 times, most recently from 66b95aa to b1ca0ff Compare January 24, 2025 12:19
@qstokkink qstokkink force-pushed the fix_32bitwin_save_path branch from b1ca0ff to 4c7e23d Compare January 24, 2025 12:25
@qstokkink qstokkink changed the title WIP: Fixed win32 checkpoint resume SEGFAULT READY: Fixed win32 checkpoint resume SEGFAULT Jan 24, 2025
@qstokkink qstokkink marked this pull request as ready for review January 24, 2025 12:34
@qstokkink qstokkink changed the title READY: Fixed win32 checkpoint resume SEGFAULT Fixed win32 checkpoint resume SEGFAULT Jan 27, 2025
@qstokkink qstokkink merged commit 9128b5c into Tribler:main Jan 27, 2025
7 checks passed
@qstokkink qstokkink deleted the fix_32bitwin_save_path branch January 27, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libtorrent 32-bit Windows build segfaults on partial resume_data
2 participants
@qstokkink @egbertbouman