Refactor streaming #8438
Merged
Refactor streaming #8438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egbertbouman
force-pushed
the
streaming
branch
4 times, most recently
from
fb7b193 to
765f5d9
Compare
egbertbouman
force-pushed
the
streaming
branch
from
765f5d9 to
567534d
Compare
egbertbouman
force-pushed
the
streaming
branch
from
567534d to
f4743fd
Compare
|
validate |
qstokkink
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the current broken streaming logic, and addresses various issues causing the videoplayer to stop/crash in the middle of the video.
I've also added a streaming option to the GUI, but enabled it only when in dev mode and using Chrome, since only Chrome supports MKV files (unofficially). As long as the video file is supported by Chrome, it's working fine.
The big remaining issue is that some commonly used audio codes (e.g. (E)AC3) aren't supported, so you'll end up with video without audio. This happens a lot, unfortunately. The next step would be to transcode video files in realtime (with ffmpeg) in order to improve compatibility.