Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP-32] Add support for signature verification using JWKS json #58

Merged
merged 8 commits into from
May 5, 2022
Merged

[PHP-32] Add support for signature verification using JWKS json #58

merged 8 commits into from
May 5, 2022

Conversation

stefandanaita
Copy link
Member

No description provided.

@stefandanaita stefandanaita requested a review from a team as a code owner April 11, 2022 18:10
lighe
lighe approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@lighe lighe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lboynton
Copy link
Member

lboynton commented Apr 12, 2022 •
edited
Loading

Changelog/readme updates?

@lboynton
Copy link
Member

Does this address #44?

@alexheretic
Copy link
Contributor

Yeah as I said in #44 (comment) I think the php readme could be a little more consistent with the other langs. In particular, we don't need to mention server-side verification which we don't expect clients to use. Instead a simple signing snippet & a jwks webhook verify snippet shows the two ways we expect clients to use this.

And it would great to see #47 & #51 examples later too!

@stefandanaita
Copy link
Member Author

Yeah as I said in #44 (comment) I think the php readme could be a little more consistent with the other langs. In particular, we don't need to mention server-side verification which we don't expect clients to use. Instead a simple signing snippet & a jwks webhook verify snippet shows the two ways we expect clients to use this.

And it would great to see #47 & #51 examples later too!

Sorry, I was on holiday for the past weeks. I'll take care of those points separately. For now we need this merged in so that we can do jwks fetching & signature verification in the client library.

@stefandanaita stefandanaita merged commit 707cb79 into main May 5, 2022
@stefandanaita stefandanaita deleted the php-32/multiple-jwks branch May 5, 2022 08:27
alexheretic pushed a commit that referenced this pull request Jul 11, 2022
@tl-alex-butler2
Squashed commit of the following:
367a325 
commit 4a755fb
Author: Alex Butler <[email protected]>
Date:   Mon Jul 11 18:07:53 2022 +0100

    C#: Add path arg validation to Signer & Verifier (#73)

    * C#: Add path arg validation to Signer & Verifier

    * Update java & php ci rules

    * Update all ci lang filters

    * Keep java tags-ignore ci

commit bc99945
Author: Marco Tormento <[email protected]>
Date:   Fri Jul 1 18:52:07 2022 +0200

    Removed symlinks for license files (#72)

commit 6c9b46c
Author: Alessandro Zanin <[email protected]>
Date:   Thu Jun 30 09:58:42 2022 +0200

    Path argument validation (#71)

    * Add path validation

    * Update changelog

    * Bump version

commit acbbe1e
Author: Alex Butler <[email protected]>
Date:   Wed Jun 29 13:43:17 2022 +0100

    Release nodejs v0.1.3

commit ad8fe1f
Author: Alex Butler <[email protected]>
Date:   Wed Jun 29 12:42:47 2022 +0100

    nodejs: Add path validation (#70)

commit 64d8701
Author: Alessandro Zanin <[email protected]>
Date:   Wed Jun 29 11:12:02 2022 +0200

    Improve WebhookVerificationHandler (#68)

commit eb0e40b
Author: Alex Butler <[email protected]>
Date:   Tue Jun 21 10:48:20 2022 +0100

    Update rust example dependencies (#67)

commit 707cb79
Author: Stefan Danaita <[email protected]>
Date:   Thu May 5 09:27:03 2022 +0100

    [PHP-32] Add support for signature verification using JWKS json (#58)

    * [PHP-32] Add support for signature verification using JWKS json

    * [PHP-32] Formatting

    * [PHP-32] PHPStan

    * [PHP-32] Changelog

    * [PHP-32] Readme

    * [PHP-32] Backfill changelog with v0.0.2

    * [PHP-32] Backfill changelog with v0.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lboynton lboynton lboynton approved these changes

@lighe lighe lighe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefandanaita @lboynton @alexheretic @lighe